The updates to *.gwt.xml are to add back dependencies so that you can run CompileModule on them as a top level module. Some modules seemed to be declared as if they did not require User.gwt.xml, but it turns out they really do.
http://gwt-code-reviews.appspot.com/1448808/diff/6001/dev/core/src/com/google/gwt/dev/CompileModule.java File dev/core/src/com/google/gwt/dev/CompileModule.java (right): http://gwt-code-reviews.appspot.com/1448808/diff/6001/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode54 dev/core/src/com/google/gwt/dev/CompileModule.java:54: * On 2011/06/06 18:11:36, jbrosenberg wrote:
Makes sense to post-pone. Add a TODO?
Added.
Seems it would be nice to clean up the inherted module inconsistencies
too (e.g.
add User to Logging's inherits).
I went ahead and did that while looking for the best way to manually compile the modules in gwt-user.
Can we add warnings somehow wherever undeclared dependencies exist? I wasn't aware that there could be circular
inheritences, If we want to make a warning, we need to clean up the User.gwt.xml hierarchy first, because it is rife with them.
is that a requirement, a loophole, or a feature?
It is convenient, I have no idea if its meant to be a desirable thing. http://gwt-code-reviews.appspot.com/1448808/diff/6001/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode122 dev/core/src/com/google/gwt/dev/CompileModule.java:122: public static void main(String[] args) { On 2011/06/03 20:13:54, tobyr wrote:
This code is almost identical to Compile.main as well as others. Can
we refactor
it?
It's especially disturbing to see the 4-line comment about System.exit duplicated in 11 different places in our codebase.
I added a TODO(). http://gwt-code-reviews.appspot.com/1448808/diff/6001/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (right): http://gwt-code-reviews.appspot.com/1448808/diff/6001/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java#newcode207 dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java:207: * Free up memory no longer needed in later compile stages. After calling this On 2011/06/03 19:48:40, jbrosenberg wrote:
s/ResourceOraclewill/ResourceOracle will/
(missed that last time) Done. http://gwt-code-reviews.appspot.com/1448808/diff/7007/dev/core/src/com/google/gwt/dev/CompileModule.java File dev/core/src/com/google/gwt/dev/CompileModule.java (right): http://gwt-code-reviews.appspot.com/1448808/diff/7007/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode190 dev/core/src/com/google/gwt/dev/CompileModule.java:190: On 2011/06/06 18:11:36, jbrosenberg wrote:
maybe move this TODO (or duplicate it) at the bottom of the class
level javadoc,
where you describe the order dependency.
Done. http://gwt-code-reviews.appspot.com/1448808/diff/7007/dev/core/src/com/google/gwt/dev/Precompile.java File dev/core/src/com/google/gwt/dev/Precompile.java (right): http://gwt-code-reviews.appspot.com/1448808/diff/7007/dev/core/src/com/google/gwt/dev/Precompile.java#newcode400 dev/core/src/com/google/gwt/dev/Precompile.java:400: /** On 2011/06/06 18:11:36, jbrosenberg wrote:
.gwtar
Done. http://gwt-code-reviews.appspot.com/1448808/diff/7007/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (right): http://gwt-code-reviews.appspot.com/1448808/diff/7007/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java#newcode95 dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java:95: /** On 2011/06/06 18:11:36, jbrosenberg wrote:
.gwtar
Done. http://gwt-code-reviews.appspot.com/1448808/diff/7007/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java#newcode221 dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java:221: * Free up memory no longer needed in later compile stages. After calling this On 2011/06/06 18:11:36, jbrosenberg wrote:
s/ResourceOraclewill/ResourceOracle will/
Done. http://gwt-code-reviews.appspot.com/1448808/diff/7007/user/build.xml File user/build.xml (right): http://gwt-code-reviews.appspot.com/1448808/diff/7007/user/build.xml#newcode1 user/build.xml:1: <project name="user" default="build" basedir="."> On 2011/06/06 18:11:36, jbrosenberg wrote:
hard to see changes here due to reformat jitter
fixed. http://gwt-code-reviews.appspot.com/1448808/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
