Revision: 10285
Author: [email protected]
Date: Mon Jun 6 12:20:50 2011
Log: Disable regex checking of URLs in SafeUriHostedModeUtils; this
regex appears to
cause stack overflows in some cases.
Review at http://gwt-code-reviews.appspot.com/1443813
http://code.google.com/p/google-web-toolkit/source/detail?r=10285
Modified:
/trunk/user/src/com/google/gwt/safehtml/shared/SafeUriHostedModeUtils.java
=======================================
---
/trunk/user/src/com/google/gwt/safehtml/shared/SafeUriHostedModeUtils.java
Mon Jun 6 10:00:08 2011
+++
/trunk/user/src/com/google/gwt/safehtml/shared/SafeUriHostedModeUtils.java
Mon Jun 6 12:20:50 2011
@@ -104,9 +104,11 @@
}
private static boolean isValidUri(String uri) {
- if (!uri.matches(HREF_UCSCHAR)) {
- return false;
- }
+ // TODO(xtof): The regex appears to cause stack overflows in some
cases.
+ // Investigate and re-enable.
+ // if (!uri.matches(HREF_UCSCHAR)) {
+ // return false;
+ // }
/*
* pre-process to turn href-ucschars into ucschars, and encode to URI.
*
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
