Reviewers: zundel,

Message:
One of the last major pieces of UnifyAst.  This patch makes SOYC
actually work.

We NEVER turn on SOYC when building serialized ASTs with GwtAstBuilder,
because you don't know whether SOYC is going to be used or not in
subsequent compiles.  So we get around the issue by replacing the "bare
bones" SourceInfos with correlated SourceInfos after UnifyAst, only when
SOYC is on.

If you enable x.gwt.astBuilder, you should get a valid compile report
that is analogous to the one you get with enabling it.  It's difficult
to diff because things aren't in the same order... the split points are
in different order, and there's other small differences.  But the data
looks essentially the same when I eyeball it.



Please review this at http://gwt-code-reviews.appspot.com/1455801/

Affected files:
  M dev/core/src/com/google/gwt/core/ext/soyc/impl/StoryRecorder.java
  M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
  M dev/core/src/com/google/gwt/dev/jjs/SourceInfoCorrelation.java
  M dev/core/src/com/google/gwt/dev/jjs/ast/JNode.java
  M dev/core/src/com/google/gwt/dev/jjs/impl/CastNormalizer.java
  M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
  M dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java
  A dev/core/src/com/google/gwt/dev/jjs/impl/SourceInfoCorrelator.java
  M dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to