LGTM - and much nicer

We should note the breaking change to former subclasses of
ResizeComposite in the release notes.  It probably won't affect anyone,
but you never know.


http://gwt-code-reviews.appspot.com/1453807/diff/1/samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/desktop/MobileWebAppShellDesktop.java
File
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/desktop/MobileWebAppShellDesktop.java
(right):

http://gwt-code-reviews.appspot.com/1453807/diff/1/samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/desktop/MobileWebAppShellDesktop.java#newcode28
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/desktop/MobileWebAppShellDesktop.java:28:
import com.google.gwt.sample.mobilewebapp.client.ClientFactory;
Unused import - you can inline the full path into the JavaDoc comment
where this is used.

http://gwt-code-reviews.appspot.com/1453807/diff/1/user/src/com/google/gwt/user/client/ui/AbstractComposite.java
File user/src/com/google/gwt/user/client/ui/AbstractComposite.java
(right):

http://gwt-code-reviews.appspot.com/1453807/diff/1/user/src/com/google/gwt/user/client/ui/AbstractComposite.java#newcode78
user/src/com/google/gwt/user/client/ui/AbstractComposite.java:78: throw
new IllegalStateException("Composite.initWidget() may only be " +
"called once.");
Composite.initWidget()/AbstractComposite.initWidget()

http://gwt-code-reviews.appspot.com/1453807/diff/1/user/src/com/google/gwt/user/client/ui/StackLayoutPanel.java
File user/src/com/google/gwt/user/client/ui/StackLayoutPanel.java
(right):

http://gwt-code-reviews.appspot.com/1453807/diff/1/user/src/com/google/gwt/user/client/ui/StackLayoutPanel.java#newcode98
user/src/com/google/gwt/user/client/ui/StackLayoutPanel.java:98: public
class StackLayoutPanel extends RequiresResizeComposite<LayoutPanel>
implements HasWidgets,
Breaking change for anyone that assumes StackLayoutPanel extends
ResizeComposite.

Hopefully its subtle enough that it won't break anyone.

http://gwt-code-reviews.appspot.com/1453807/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to