http://gwt-code-reviews.appspot.com/1453807/diff/1/samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/desktop/MobileWebAppShellDesktop.java File samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/desktop/MobileWebAppShellDesktop.java (right):
http://gwt-code-reviews.appspot.com/1453807/diff/1/samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/desktop/MobileWebAppShellDesktop.java#newcode28 samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/desktop/MobileWebAppShellDesktop.java:28: import com.google.gwt.sample.mobilewebapp.client.ClientFactory; On 2011/06/07 14:01:36, jlabanca wrote:
Unused import - you can inline the full path into the JavaDoc comment
where this
is used.
Done. http://gwt-code-reviews.appspot.com/1453807/diff/1/user/src/com/google/gwt/user/client/ui/AbstractComposite.java File user/src/com/google/gwt/user/client/ui/AbstractComposite.java (right): http://gwt-code-reviews.appspot.com/1453807/diff/1/user/src/com/google/gwt/user/client/ui/AbstractComposite.java#newcode78 user/src/com/google/gwt/user/client/ui/AbstractComposite.java:78: throw new IllegalStateException("Composite.initWidget() may only be " + "called once."); On 2011/06/07 14:01:36, jlabanca wrote:
Composite.initWidget()/AbstractComposite.initWidget()
Done. http://gwt-code-reviews.appspot.com/1453807/diff/1/user/src/com/google/gwt/user/client/ui/StackLayoutPanel.java File user/src/com/google/gwt/user/client/ui/StackLayoutPanel.java (right): http://gwt-code-reviews.appspot.com/1453807/diff/1/user/src/com/google/gwt/user/client/ui/StackLayoutPanel.java#newcode98 user/src/com/google/gwt/user/client/ui/StackLayoutPanel.java:98: public class StackLayoutPanel extends RequiresResizeComposite<LayoutPanel> implements HasWidgets, Good point. Noted this in http://code.google.com/p/google-web-toolkit/issues/detail?id=4665 On 2011/06/07 14:01:36, jlabanca wrote:
Breaking change for anyone that assumes StackLayoutPanel extends ResizeComposite.
Hopefully its subtle enough that it won't break anyone.
http://gwt-code-reviews.appspot.com/1453807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
