http://gwt-code-reviews.appspot.com/1455801/diff/1/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java (right):
http://gwt-code-reviews.appspot.com/1455801/diff/1/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java#newcode540 dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java:540: if (GwtAstBuilder.ENABLED) { the blocks of this if statement separate out nicely into 2 methods using the eclipse extract method refactoring tool... http://gwt-code-reviews.appspot.com/1455801/diff/1/dev/core/src/com/google/gwt/dev/jjs/SourceInfoCorrelation.java File dev/core/src/com/google/gwt/dev/jjs/SourceInfoCorrelation.java (right): http://gwt-code-reviews.appspot.com/1455801/diff/1/dev/core/src/com/google/gwt/dev/jjs/SourceInfoCorrelation.java#newcode52 dev/core/src/com/google/gwt/dev/jjs/SourceInfoCorrelation.java:52: public SourceInfoCorrelation(SourceInfoCorrelation parent, SourceOrigin origin) { why not use parent.makeChild(origin)? http://gwt-code-reviews.appspot.com/1455801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java (right): http://gwt-code-reviews.appspot.com/1455801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java#newcode274 dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java:274: for (JArrayType arrayType : program.getAllArrayTypes()) { I'm not sure if this no longer jives with the comment, or the comment really mean, all instantiated types (which makes sense). http://gwt-code-reviews.appspot.com/1455801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/SourceInfoCorrelator.java File dev/core/src/com/google/gwt/dev/jjs/impl/SourceInfoCorrelator.java (right): http://gwt-code-reviews.appspot.com/1455801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/SourceInfoCorrelator.java#newcode46 dev/core/src/com/google/gwt/dev/jjs/impl/SourceInfoCorrelator.java:46: * TODO(scottb): implement. stale TODO()? http://gwt-code-reviews.appspot.com/1455801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java File dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java (right): http://gwt-code-reviews.appspot.com/1455801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java#newcode286 dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java:286: addAssignment(param, new JParameterRef(SourceOrigin.UNKNOWN, param)); I realize you are just mucking with SouceInfo, but what is your opinion about creating a fake assignment, vs. introducing something like 'volatile' like you did for JMethodCall? http://gwt-code-reviews.appspot.com/1455801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
