Updated patch.
http://gwt-code-reviews.appspot.com/1455801/diff/1/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java (right): http://gwt-code-reviews.appspot.com/1455801/diff/1/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java#newcode540 dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java:540: if (GwtAstBuilder.ENABLED) { The second block is going to get deleted soon, I hope! http://gwt-code-reviews.appspot.com/1455801/diff/1/dev/core/src/com/google/gwt/dev/jjs/SourceInfoCorrelation.java File dev/core/src/com/google/gwt/dev/jjs/SourceInfoCorrelation.java (right): http://gwt-code-reviews.appspot.com/1455801/diff/1/dev/core/src/com/google/gwt/dev/jjs/SourceInfoCorrelation.java#newcode52 dev/core/src/com/google/gwt/dev/jjs/SourceInfoCorrelation.java:52: public SourceInfoCorrelation(SourceInfoCorrelation parent, SourceOrigin origin) { On 2011/06/07 18:01:06, zundel wrote:
why not use parent.makeChild(origin)?
I wanted to be explicit about it, leaving no chance that I was calling SourceOrigin.makeChild() and getting a no-op. makeChild() could end up going away in the cleanup once GwtAstBuilder is the standard. http://gwt-code-reviews.appspot.com/1455801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java (right): http://gwt-code-reviews.appspot.com/1455801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java#newcode274 dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java:274: for (JArrayType arrayType : program.getAllArrayTypes()) { Fixed the comment. http://gwt-code-reviews.appspot.com/1455801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/SourceInfoCorrelator.java File dev/core/src/com/google/gwt/dev/jjs/impl/SourceInfoCorrelator.java (right): http://gwt-code-reviews.appspot.com/1455801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/SourceInfoCorrelator.java#newcode46 dev/core/src/com/google/gwt/dev/jjs/impl/SourceInfoCorrelator.java:46: * TODO(scottb): implement. Updated patch forthcoming. :) http://gwt-code-reviews.appspot.com/1455801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java File dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java (right): http://gwt-code-reviews.appspot.com/1455801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java#newcode286 dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java:286: addAssignment(param, new JParameterRef(SourceOrigin.UNKNOWN, param)); In this case, it's completely local to TypeTightener, so I wouldn't do anything like mutate the AST to support this. I would just mark it locally in some way. This is basically a local way of marking it, albeit a hacky one that takes advantage of the fact that we don't resolve cycles of any sort. http://gwt-code-reviews.appspot.com/1455801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
