LGTM w/nitlets

http://gwt-code-reviews.appspot.com/1453810/diff/3001/dev/core/src/com/google/gwt/dev/jjs/AstConstructor.java
File dev/core/src/com/google/gwt/dev/jjs/AstConstructor.java (right):

http://gwt-code-reviews.appspot.com/1453810/diff/3001/dev/core/src/com/google/gwt/dev/jjs/AstConstructor.java#newcode72
dev/core/src/com/google/gwt/dev/jjs/AstConstructor.java:72:
Do we still need the '(3)' here?

http://gwt-code-reviews.appspot.com/1453810/diff/3001/dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java
File dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java (right):

http://gwt-code-reviews.appspot.com/1453810/diff/3001/dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java#newcode519
dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java:519:
assimilateUnit(cc.getUnit());
can just do:
assert program.getFromTypeMap(sourceTypeName) != null;

http://gwt-code-reviews.appspot.com/1453810/diff/3001/dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java#newcode837
dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java:837: * Main loop:
run through the queue doing deferred resolution. We could have
s/but a work queues/but work queues

http://gwt-code-reviews.appspot.com/1453810/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to