Do we have a unit test which exercises this (and includes regression for
the non-SubIterator case?   Is this only a problem in the new
GwtAstBuilder?  Isn't there a similar issue in the old GenerateJavaAST
code?


http://gwt-code-reviews.appspot.com/1450814/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java
File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java
(right):

http://gwt-code-reviews.appspot.com/1450814/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java#newcode2780
dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java:2780: }
catch (Exception e) {
Do we expect this error condition ever to happen?  Or is this defensive
in the case of changes to jdt over time?

http://gwt-code-reviews.appspot.com/1450814/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to