LGTM
(but I'd love a comment, and a detailed TODO for the test-case which
triggered this fix, so that if someone wants to create a unit test, the
scenario is clear).

Also, I'm curious, if GenerateJavaAST already has this hack, why didn't
GwtAstBuilder also have it initially?  Any point in going ahead with
adding the caching of the Field also to GenerateJavaAST here?  Or are we
deprecating GenerateJavaAST eventually anyway?


http://gwt-code-reviews.appspot.com/1450814/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java
File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java
(right):

http://gwt-code-reviews.appspot.com/1450814/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java#newcode2776
dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java:2776:
InternalCompilerException.preload();
How about a comment describing why this is needed here.

http://gwt-code-reviews.appspot.com/1450814/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to