LGTM

http://gwt-code-reviews.appspot.com/1446818/diff/1/user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java
File user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java
(right):

http://gwt-code-reviews.appspot.com/1446818/diff/1/user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java#newcode69
user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java:69:
public static final String CACHED_TYPE_INFO_KEY = "ctik";
Unless there are some real constraints, would prefer the actual value of
this constant to be a little less brief. For example, would be less
opaque in debugging contexts.

http://gwt-code-reviews.appspot.com/1446818/diff/1010/dev/core/src/com/google/gwt/dev/javac/rebind/CachedPropertyInformation.java
File
dev/core/src/com/google/gwt/dev/javac/rebind/CachedPropertyInformation.java
(right):

http://gwt-code-reviews.appspot.com/1446818/diff/1010/dev/core/src/com/google/gwt/dev/javac/rebind/CachedPropertyInformation.java#newcode111
dev/core/src/com/google/gwt/dev/javac/rebind/CachedPropertyInformation.java:111:
"Found problem checking configuration property: " + e.getMessage());
Not good to squash the stack trace.

http://gwt-code-reviews.appspot.com/1446818/diff/1010/user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java
File user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java
(right):

http://gwt-code-reviews.appspot.com/1446818/diff/1010/user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java#newcode254
user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java:254:
boolean foundMatch =
This seems like a superfluous variable declaration

http://gwt-code-reviews.appspot.com/1446818/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to