LGTM w/ suggestion.
http://gwt-code-reviews.appspot.com/1464804/diff/4001/dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java File dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java (right): http://gwt-code-reviews.appspot.com/1464804/diff/4001/dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java#newcode109 dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java:109: if (((CachedCompilationUnit) newUnit).getTypesSerializedVersion() != GwtAstBuilder The cast seems to imply a hard contract here. If you want to commit as-is, I think that's fine, but I think it'd be better to change the sig to CachedCompilationUnit and thread the API changes back to wherever they are needed. http://gwt-code-reviews.appspot.com/1464804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
