http://gwt-code-reviews.appspot.com/1464804/diff/5004/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
(right):

http://gwt-code-reviews.appspot.com/1464804/diff/5004/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java#newcode343
dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java:343:
for (CompilationUnit unit : module.getUnits().values()) {
Maybe add an assert here, for (unit instanceof CachedCompilationUnit),
maybe along with a comment explaining why we think it's safe...

http://gwt-code-reviews.appspot.com/1464804/diff/5004/dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java
File dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java (right):

http://gwt-code-reviews.appspot.com/1464804/diff/5004/dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java#newcode18
dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java:18: import
com.google.gwt.core.ext.TreeLogger;
Is this still needed here?

http://gwt-code-reviews.appspot.com/1464804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to