Now that's a good answer! So the real is is just to close the result of sourceFile.openContents()?
I would update the doc on DiskCache.tranferTo/FromStream that they don't close the stream, and then look at all the callers and make sure they do the right thing. On Fri, Jun 24, 2011 at 10:36 PM, <[email protected]> wrote: > Found the reason it fixes it. > The machine I'm testing on is not tuned for lots of files: > > [java] Caused by: java.io.FileNotFoundException: > /home/testing/gwt-orig/us\ > er/src/com/google/gwt/i18n/**client/impl/cldr/** > DateTimeFormatInfoImpl_eu.java > (Too\ > many open files) > [java] at java.io.FileInputStream.open(**Native Method) > [java] at > java.io.FileInputStream.<init>**(FileInputStream.java:137) > [java] at > com.google.gwt.dev.resource.**impl.FileResource.**openContents(F\ > ileResource.java:63) > [java] ... 7 more > > The root cause is that the the original code doesn't close the stream > returned from Resource.openContents(). Everywhere else that > diskCache.transferFromStream() is used, its in the context of a > readObject() override, so this is the only place where this would cause > a problem. > > FYI, here's the original stack trace. I've seen them before but not in > such a reproducable way > > [java] [ERROR] Unexpected internal compiler error > [java] java.lang.NullPointerException > [java] at > com.google.gwt.dev.util.**DiskCache.transferFromStream(** > DiskCache.java:154) > [java] at > com.google.gwt.dev.javac.**SourceFileCompilationUnit.** > asCachedCompilationUnit(**SourceFileCompilationUnit.**java:59) > [java] at > com.google.gwt.dev.javac.**CompilationUnitArchive.**addUnit(** > CompilationUnitArchive.java:**88) > [java] at > com.google.gwt.dev.**CompileModule.run(**CompileModule.java:283) > [java] at > com.google.gwt.dev.**CompileModule$1.run(**CompileModule.java:162) > [java] at > com.google.gwt.dev.**CompileTaskRunner.doRun(**CompileTaskRunner.java:88) > [java] at > com.google.gwt.dev.**CompileTaskRunner.**runWithAppropriateLogger(** > CompileTaskRunner.java:82) > [java] at > com.google.gwt.dev.**CompileModule.main(**CompileModule.java:165) > > > > > > > > > http://gwt-code-reviews.**appspot.com/1461803/<http://gwt-code-reviews.appspot.com/1461803/> > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
