http://gwt-code-reviews.appspot.com/1461803/diff/4003/dev/core/src/com/google/gwt/dev/javac/SourceFileCompilationUnit.java File dev/core/src/com/google/gwt/dev/javac/SourceFileCompilationUnit.java (right):
http://gwt-code-reviews.appspot.com/1461803/diff/4003/dev/core/src/com/google/gwt/dev/javac/SourceFileCompilationUnit.java#newcode60 dev/core/src/com/google/gwt/dev/javac/SourceFileCompilationUnit.java:60: if (sourceToken < 0) { I think 'in' can end up being null, without an exception being thrown (e.g. in File/ZipResource.openConnection(), it catch any IOException and return null). Shouldn't this handle that possibility a bit more gracefully? The assert for (in != null) in transferFromStream would seemingly blow up in that case.... http://gwt-code-reviews.appspot.com/1461803/diff/4003/dev/core/src/com/google/gwt/dev/util/DiskCache.java File dev/core/src/com/google/gwt/dev/util/DiskCache.java (right): http://gwt-code-reviews.appspot.com/1461803/diff/4003/dev/core/src/com/google/gwt/dev/util/DiskCache.java#newcode139 dev/core/src/com/google/gwt/dev/util/DiskCache.java:139: * Write the rest of the data in an input stream to disk. Note: this method s/close the in InputStream/close the InputStream http://gwt-code-reviews.appspot.com/1461803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
