worth testing new generator version invalidation logic?


http://gwt-code-reviews.appspot.com/1468804/diff/2002/dev/core/src/com/google/gwt/core/ext/RebindMode.java
File dev/core/src/com/google/gwt/core/ext/RebindMode.java (right):

http://gwt-code-reviews.appspot.com/1468804/diff/2002/dev/core/src/com/google/gwt/core/ext/RebindMode.java#newcode26
dev/core/src/com/google/gwt/core/ext/RebindMode.java:26: * Indicates
nothing new was created, use pre-existing type information.
s/Indicates nothing new was created/No generated code is needed to
satisfy this rebind./

http://gwt-code-reviews.appspot.com/1468804/diff/2002/dev/core/src/com/google/gwt/core/ext/RebindMode.java#newcode49
dev/core/src/com/google/gwt/core/ext/RebindMode.java:49: * should be
used.
Link back to the GeneratorContext#tryReuseTypeFromCache() method?

http://gwt-code-reviews.appspot.com/1468804/diff/2002/user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java
File
user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java
(right):

http://gwt-code-reviews.appspot.com/1468804/diff/2002/user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java#newcode498
user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java:498:
assert cti instanceof Serializable;
s/cti/cri/

http://gwt-code-reviews.appspot.com/1468804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to