http://gwt-code-reviews.appspot.com/1468804/diff/7001/dev/core/src/com/google/gwt/core/ext/RebindMode.java
File dev/core/src/com/google/gwt/core/ext/RebindMode.java (right):

http://gwt-code-reviews.appspot.com/1468804/diff/7001/dev/core/src/com/google/gwt/core/ext/RebindMode.java#newcode52
dev/core/src/com/google/gwt/core/ext/RebindMode.java:52:
USE_ALL_NEW_WITH_NO_CACHING,
Well no, it is useful in a couple of contexts.  This mode allows the
framework to not bother creating a cache entry, and avoid incurring the
overhead of doing so, if the cache entry can't be made use of anyway.

First, in the code that wraps legacy Generators, this RebindMode is
always used.

Second, even for generators which implement IncrementalGenerator, there
are certain conditions whereby the generator can determine positively
that its result should not be cached, since it can't possibly make use
of any cached information subsequently.

Examples of this exist for both the RPC and ClientBundle.  In the case
of RPC, see ProxyCreator.java, line 875 (which gets returned to line
380).  This is basically saying that if a particular RPC implementation
is using deRPC, don't attempt caching, since support for deRPC wasn't
added.

In the case of AbstractClientBundleGenerator, see line 715 (which gets
returned to line 394).  In this case, it indicates that if a
ClientBundle calls for a ResourceGenerator implementation that doesn't
implement the SupportsGeneratorResultCaching interface, then this client
bundle should never attempt to make use of caching.  Since developers
can sub-class ResourceGenerator, or other GWT developers can add new
ResourceGenerators, this makes sure that they've considered incremental
caching in how they've implemented things, and if not,
AbstractClientBundleGenerator won't trust it as being cacheable.

http://gwt-code-reviews.appspot.com/1468804/diff/7001/dev/core/src/com/google/gwt/core/ext/RebindResult.java
File dev/core/src/com/google/gwt/core/ext/RebindResult.java (right):

http://gwt-code-reviews.appspot.com/1468804/diff/7001/dev/core/src/com/google/gwt/core/ext/RebindResult.java#newcode48
dev/core/src/com/google/gwt/core/ext/RebindResult.java:48: * cache reuse
decisions.
On 2011/08/03 19:50:55, rjrjr wrote:
Could you point out explicitly that this data is cached per generated
type?

Done.

http://gwt-code-reviews.appspot.com/1468804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to