I had a few nits below but I felt a bit out of context. Is there an
overview somewhere of what you guys are trying to accomplish? What
should rendering for Cells look like?


http://gwt-code-reviews.appspot.com/1466809/diff/1/user/src/com/google/gwt/uibinder/client/UiRenderer.java
File user/src/com/google/gwt/uibinder/client/UiRenderer.java (right):

http://gwt-code-reviews.appspot.com/1466809/diff/1/user/src/com/google/gwt/uibinder/client/UiRenderer.java#newcode32
user/src/com/google/gwt/uibinder/client/UiRenderer.java:32: * @param
cell {@link com.google.gwt.cell.client.Cell Cell} that will receive the
event
You should add a blank line before @param

http://gwt-code-reviews.appspot.com/1466809/diff/1/user/src/com/google/gwt/uibinder/client/UiRendererUtils.java
File user/src/com/google/gwt/uibinder/client/UiRendererUtils.java
(right):

http://gwt-code-reviews.appspot.com/1466809/diff/1/user/src/com/google/gwt/uibinder/client/UiRendererUtils.java#newcode38
user/src/com/google/gwt/uibinder/client/UiRendererUtils.java:38: *
Retrieves a specific element within a previously rendered elements.
/s/elements./element./

http://gwt-code-reviews.appspot.com/1466809/diff/1/user/src/com/google/gwt/uibinder/client/UiRendererUtils.java#newcode41
user/src/com/google/gwt/uibinder/client/UiRendererUtils.java:41: *
@param fieldName name of the field to retrieve
you forgo the javadoc for attribute (I was actually curious about that
one :-) )

http://gwt-code-reviews.appspot.com/1466809/diff/1/user/src/com/google/gwt/uibinder/client/UiRendererUtils.java#newcode45
user/src/com/google/gwt/uibinder/client/UiRendererUtils.java:45: Element
root = findRootElement(parent, attribute);
Do you really need the root element? Couldn't you just check if parent
is attached?

http://gwt-code-reviews.appspot.com/1466809/diff/1/user/src/com/google/gwt/uibinder/client/UiRendererUtils.java#newcode87
user/src/com/google/gwt/uibinder/client/UiRendererUtils.java:87: assert
isRenderedElementSingleChild(ret)//
Are the trailing "//" on purpose?

http://gwt-code-reviews.appspot.com/1466809/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to