http://gwt-code-reviews.appspot.com/1466809/diff/3020/user/src/com/google/gwt/uibinder/client/AbstractUiRenderer.java File user/src/com/google/gwt/uibinder/client/AbstractUiRenderer.java (right):
http://gwt-code-reviews.appspot.com/1466809/diff/3020/user/src/com/google/gwt/uibinder/client/AbstractUiRenderer.java#newcode38 user/src/com/google/gwt/uibinder/client/AbstractUiRenderer.java:38: public boolean isParentOrRenderer(Element parent) { Can this use UiRendererUtilsImpl#findRootElement()? Seems like the code is very similar. http://gwt-code-reviews.appspot.com/1466809/diff/3020/user/src/com/google/gwt/uibinder/client/UiRendererUtilsImpl.java File user/src/com/google/gwt/uibinder/client/UiRendererUtilsImpl.java (right): http://gwt-code-reviews.appspot.com/1466809/diff/3020/user/src/com/google/gwt/uibinder/client/UiRendererUtilsImpl.java#newcode155 user/src/com/google/gwt/uibinder/client/UiRendererUtilsImpl.java:155: int endOfFirstTag = html.indexOf(">"); This still needs to handle self closing (ends in />) Strings: <div id="placeholder" /> You can copy the code from RenderableStamper.stamp(): if (html.charAt(endOfFirstTag - 1) == '/') { endOfFirstTag--; } http://gwt-code-reviews.appspot.com/1466809/diff/3020/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (right): http://gwt-code-reviews.appspot.com/1466809/diff/3020/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode1441 user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:1441: && jMethod.getParameterTypes().length >= 1 You should also handle the case where render() is declared without any parameters. This conditional would skip over the no-arg case without throwing an error. http://gwt-code-reviews.appspot.com/1466809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
