Oops, there's a problem, I need one more cycle before I can commit. Will send patch tonite. :(
On Fri, Jul 1, 2011 at 1:43 PM, <[email protected]> wrote: > > I made the fixes and submitted it. Since most people are headed out of > the office for the holiday, I need to get it in early to see if I need > to revert it before everyone is gone. :) > > > > http://gwt-code-reviews.appspot.com/1447821/diff/15001/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java > File dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java > (right): > > http://gwt-code-reviews.appspot.com/1447821/diff/15001/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java#newcode93 > dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java:93: > On 2011/07/01 10:24:38, jbrosenberg wrote: >> >> whitespace > > Done. > > http://gwt-code-reviews.appspot.com/1447821/diff/15001/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java#newcode600 > dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java:600: > instantiatedTypes.add(type); > On 2011/07/01 10:24:38, jbrosenberg wrote: >> >> Suggest combining all this into 1 method call to something like >> ("maybeRescueClassLiteral(type)"), and then mRCL contains logic to see > > if >> >> classLiteralsToBeRescuedIfGetClassLive is null or not, to decide > > whether to >> >> rescue or mark for rescue. > > Done. > > http://gwt-code-reviews.appspot.com/1447821/diff/15001/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java#newcode769 > dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java:769: > if (classLiteralsToBeRescuedIfGetClassIsLive != null) { > Not sure, but rescueClassLiteral can end up invoking this function > again, and you'll get a concurrent modification exception if you don't > clone, and if you do, you end up with extra work. > > On 2011/07/01 10:24:38, jbrosenberg wrote: >> >> is re-entrant the right term (I usually think of it wrt to > > concurrency)? > > http://gwt-code-reviews.appspot.com/1447821/diff/15001/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java#newcode870 > dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java:870: > On 2011/07/01 10:24:38, jbrosenberg wrote: >> >> whitespace > > Done. > > http://gwt-code-reviews.appspot.com/1447821/diff/15001/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java#newcode917 > dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java:917: > /** > On 2011/07/01 10:24:38, jbrosenberg wrote: >> >> C > > IDE has bizarre bug where it was randomly inserting these. > > http://gwt-code-reviews.appspot.com/1447821/ > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
