http://gwt-code-reviews.appspot.com/1447821/diff/6053/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java
File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java
(right):

http://gwt-code-reviews.appspot.com/1447821/diff/6053/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java#newcode516
dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java:516: }
else {
maybe a little cleaner to break the control flow into:

else if (currentClass == program.getIndexedType("Array")) {
  ...
} else {
  ...
}

http://gwt-code-reviews.appspot.com/1447821/diff/6053/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java#newcode521
dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java:521: }
else {
comment explaining why?

http://gwt-code-reviews.appspot.com/1447821/diff/6053/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java
File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java
(right):

http://gwt-code-reviews.appspot.com/1447821/diff/6053/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java#newcode2161
dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java:2161: //
don't implement, fall through to Object.getClass()
why do arrays need to be different (add to comment?)

http://gwt-code-reviews.appspot.com/1447821/diff/6053/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java#newcode2763
dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java:2763:
private static final long AST_VERSION = 2;
do we need to bump this version, since array classes will now be
serialized differently?

http://gwt-code-reviews.appspot.com/1447821/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to