On 2011/07/06 13:51:57, zhuyi wrote:
On 2011/07/06 06:22:38, stephenh wrote: > > According to the current code structure, if we want to make the > > variable non-static, we may need to pass the propertyOracle
parameter to
many > > methods > > I downloaded the patch and was able to kill the "flaky" static
variable by
> changing various methods to take GeneratorContextExt (which has both TypeOracle > and PropertyOracle) instead of just TypeOracle. > > Changing existing method params from TypeOracle ->
GeneratorContextExt seemed
> like a nicer change than adding PropertyOracle as yet another method parameter, > which, as you said, could get tedious. > > I was just seeing if it would work, so I didn't do any
formatting/method
> ordering/etc., i.e. it's not perfect. But I can upload the patch if
you'd like
> to see it.
That would be great. Could you please upload the patch? Thanks!
Ray and Bob: which way do you prefer? http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
