Should we really be fixing the issue here, or should we just fix it up
in GenerateJavaScriptAST or JsNamer? There are lots of locations in the
GWT compiler where methods and fields are synthesized, so I would bet
that there are other collisions like this lurking, just not being
tripped.
Another option would be something like a utility method like
Util.createUniqueName(prefix, suffix, scope context), which could be
reused.
-Ray
On 2011/07/07 22:54:59, scottb wrote:
http://gwt-code-reviews.appspot.com/1467812/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/JsoDevirtualizer.java
File dev/core/src/com/google/gwt/dev/jjs/impl/JsoDevirtualizer.java
(right):
http://gwt-code-reviews.appspot.com/1467812/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/JsoDevirtualizer.java#newcode153
dev/core/src/com/google/gwt/dev/jjs/impl/JsoDevirtualizer.java:153: //
same
signature.
Javadoc comment.
http://gwt-code-reviews.appspot.com/1467812/diff/1/dev/core/test/com/google/gwt/dev/jjs/impl/JsoDevirtualizerTest.java
File
dev/core/test/com/google/gwt/dev/jjs/impl/JsoDevirtualizerTest.java
(right):
http://gwt-code-reviews.appspot.com/1467812/diff/1/dev/core/test/com/google/gwt/dev/jjs/impl/JsoDevirtualizerTest.java#newcode74
dev/core/test/com/google/gwt/dev/jjs/impl/JsoDevirtualizerTest.java:74:
"static
Iface2 val4 = Jso2.create();");
Sanity check: what happens if you change the return type to something
other than
int? I think JMethod.getSignature() includes return type.
http://gwt-code-reviews.appspot.com/1467812/diff/1/dev/core/test/com/google/gwt/dev/jjs/impl/OptimizerTestBase.java
File dev/core/test/com/google/gwt/dev/jjs/impl/OptimizerTestBase.java
(right):
http://gwt-code-reviews.appspot.com/1467812/diff/1/dev/core/test/com/google/gwt/dev/jjs/impl/OptimizerTestBase.java#newcode31
dev/core/test/com/google/gwt/dev/jjs/impl/OptimizerTestBase.java:31:
public
abstract class OptimizerTestBase extends JJSTestBase {
Any semantic changes?
http://gwt-code-reviews.appspot.com/1467812/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
