http://gwt-code-reviews.appspot.com/1467812/diff/15001/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java (right):
http://gwt-code-reviews.appspot.com/1467812/diff/15001/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java#newcode1413 dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java:1413: checkForDupMethods(x); On 2011/07/14 21:58:22, scottb wrote:
In this case the normal thing to do is change line 1425 to "return super.visit(x);". The default implementation will call the
JDeclaredType
overload.
Done. http://gwt-code-reviews.appspot.com/1467812/diff/15001/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java#newcode1628 dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java:1628: throw new InternalCompilerException("Name collision in Type " + x.getName() On 2011/07/14 21:58:22, scottb wrote:
"Signature" collision
Done. http://gwt-code-reviews.appspot.com/1467812/diff/15001/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java#newcode1632 dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java:1632: } On 2011/07/14 21:58:22, scottb wrote:
While you're in here, you could also check that each unique method has
a unique
name / poly name.
Wimped out and added a TODO() http://gwt-code-reviews.appspot.com/1467812/diff/15001/dev/core/src/com/google/gwt/dev/jjs/impl/JsoDevirtualizer.java File dev/core/src/com/google/gwt/dev/jjs/impl/JsoDevirtualizer.java (right): http://gwt-code-reviews.appspot.com/1467812/diff/15001/dev/core/src/com/google/gwt/dev/jjs/impl/JsoDevirtualizer.java#newcode155 dev/core/src/com/google/gwt/dev/jjs/impl/JsoDevirtualizer.java:155: private Map<String, Integer> jsoMethodInstances = new HashMap<String, Integer>(); On 2011/07/14 21:58:22, scottb wrote:
Javadoc instead of one-line.
Done. http://gwt-code-reviews.appspot.com/1467812/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
