http://gwt-code-reviews.appspot.com/1518803/diff/1/dev/core/src/com/google/gwt/dev/CompileModule.java File dev/core/src/com/google/gwt/dev/CompileModule.java (right):
http://gwt-code-reviews.appspot.com/1518803/diff/1/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode194 dev/core/src/com/google/gwt/dev/CompileModule.java:194: Map<String, Set<String>> unitsInArchives = new HashMap<String, Set<String>>(); I'm a little confused by this comment. When you say "session", is it referring specifically to a dev mode session? Or could it also apply to a web-mode compile? In which case what's a session? What's the significance of units being written to the classpath? http://gwt-code-reviews.appspot.com/1518803/diff/1/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode197 dev/core/src/com/google/gwt/dev/CompileModule.java:197: // modules compiled in the same session. maybe a more specific name ("newlyCompiledModules")? http://gwt-code-reviews.appspot.com/1518803/diff/1/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode231 dev/core/src/com/google/gwt/dev/CompileModule.java:231: session? http://gwt-code-reviews.appspot.com/1518803/diff/1/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode238 dev/core/src/com/google/gwt/dev/CompileModule.java:238: Is this really the right comment for this entire for loop? http://gwt-code-reviews.appspot.com/1518803/diff/1/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (right): http://gwt-code-reviews.appspot.com/1518803/diff/1/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java#newcode137 dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java:137: new LinkedHashMap<String, Class<? extends Linker>>(); whitespace? Here and below? http://gwt-code-reviews.appspot.com/1518803/diff/1/dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java File dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java (right): http://gwt-code-reviews.appspot.com/1518803/diff/1/dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java#newcode232 dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java:232: } whitespace? http://gwt-code-reviews.appspot.com/1518803/diff/1/dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java#newcode241 dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java:241: } will this add inherited modules from multiple levels in the hierarchy? Or only first level inheritance? It seems like it would be relevant to detecting whether a module's compilation units are already loaded, etc. http://gwt-code-reviews.appspot.com/1518803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
