LGTM w/a comment nit
http://gwt-code-reviews.appspot.com/1518803/diff/3002/dev/core/src/com/google/gwt/dev/CompileModule.java File dev/core/src/com/google/gwt/dev/CompileModule.java (right): http://gwt-code-reviews.appspot.com/1518803/diff/3002/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode194 dev/core/src/com/google/gwt/dev/CompileModule.java:194: Map<String, Set<String>> unitsInArchives = new HashMap<String, Set<String>>(); Ok, so can you make it a bit more clear in this comment, so we know why it's relevant to say "they may not have been written to the classpath..."? Are you saying that archive files are written to the classpath, and then reloaded from the classpath, in the same process? Or is it always a matter of writing things so that the next process (with a new classloader) will find them? In which case it make more sense to refer to in that way (since how do I know a subsequent process will even have the same classpath as the current invocation)? http://gwt-code-reviews.appspot.com/1518803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
