Overall looks pretty good. Still trying to digest this first round. I'll take another pass tomorrow. For now, just silly style suggestions.
http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverter.java File user/src/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverter.java (right): http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverter.java#newcode94 user/src/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverter.java:94: int computedCount; Can you comment on the purpose of this var? http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java File user/src/com/google/gwt/uibinder/rebind/FieldManager.java (right): http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java#newcode75 user/src/com/google/gwt/uibinder/rebind/FieldManager.java:75: if (fieldName.startsWith("get_")) { What if you move "get_" and "build_" to consts? http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java#newcode301 user/src/com/google/gwt/uibinder/rebind/FieldManager.java:301: source, this, typeOracle); move to previous line http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/rebind/FieldReference.java File user/src/com/google/gwt/uibinder/rebind/FieldReference.java (right): http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/rebind/FieldReference.java#newcode87 user/src/com/google/gwt/uibinder/rebind/FieldReference.java:87: if (logger != null) { Seems bad, in which situation logger is null? http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/rebind/FieldReference.java#newcode163 user/src/com/google/gwt/uibinder/rebind/FieldReference.java:163: for (int i = 0; i < left.types.length; i++) { I'm seeing this again. Do you think it's worth moving this to a static method in some helper class? http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/rebind/FieldReference.java#newcode222 user/src/com/google/gwt/uibinder/rebind/FieldReference.java:222: if (isNumber(leftHandType) && isNumber(rightHandType) && (rightHandType.isPrimitive() != null)) { ughh, exploding 100 cols. http://gwt-code-reviews.appspot.com/1522803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
