LGTM. Just nits.

http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverter.java
File
user/src/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverter.java
(right):

http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverter.java#newcode96
user/src/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverter.java:96:
public int computedCount() {
getComputedCount()

http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java
File user/src/com/google/gwt/uibinder/rebind/FieldManager.java (right):

http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java#newcode124
user/src/com/google/gwt/uibinder/rebind/FieldManager.java:124: // could
this conversion can be moved to FieldWriter?
"TODO"?

http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
(right):

http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode1738
user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:1738: //
TODO(rchandia) Find a better way to get the root field name
Can we now use FieldManager#stripFieldGetter()?

http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/test/com/google/gwt/uibinder/LazyWidgetBuilderSuite.java
File user/test/com/google/gwt/uibinder/LazyWidgetBuilderSuite.java
(right):

http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/test/com/google/gwt/uibinder/LazyWidgetBuilderSuite.java#newcode35
user/test/com/google/gwt/uibinder/LazyWidgetBuilderSuite.java:35:
suite.addTestSuite(UiRendererTest.class);
What do you think about copying some UiBinderSuite tests here?

http://gwt-code-reviews.appspot.com/1522803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to