http://gwt-code-reviews.appspot.com/1589803/diff/1/plugins/xpcom/ExternalWrapper.cpp File plugins/xpcom/ExternalWrapper.cpp (right):
http://gwt-code-reviews.appspot.com/1589803/diff/1/plugins/xpcom/ExternalWrapper.cpp#newcode28 plugins/xpcom/ExternalWrapper.cpp:28: #include "nsIDOMWindowInternal.h" I still see unguarded references to nsIDOMWindowInternal in this file. http://gwt-code-reviews.appspot.com/1589803/diff/1/plugins/xpcom/Makefile File plugins/xpcom/Makefile (right): http://gwt-code-reviews.appspot.com/1589803/diff/1/plugins/xpcom/Makefile#newcode138 plugins/xpcom/Makefile:138: MOZALLOC_DLLFLAGS = -lmozalloc On 2011/11/11 10:16:05, tbroyer wrote:
In http://gwt-code-reviews.appspot.com/1560803/ we talked about
refactoring the
MOZALLOC_DLLFLAGS, MOZJS_DLLFLAGS and ALLARCHCFLAGS before the 'ifeq ($(BROWSER),FF40)' (just after line 94) instead of copy/pasting them
in each
version.
indeed. please make this change. http://gwt-code-reviews.appspot.com/1589803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
