LGTM + nit
http://gwt-code-reviews.appspot.com/1589803/diff/7001/plugins/xpcom/Makefile File plugins/xpcom/Makefile (right): http://gwt-code-reviews.appspot.com/1589803/diff/7001/plugins/xpcom/Makefile#newcode141 plugins/xpcom/Makefile:141: endif nit: you could make these all independent if statements (rather than chained if-elses) and then check that the GECKO_VERSION is set to something at the end. If make weren't such an abomination of a syntax, this wouldn't be an issue. http://gwt-code-reviews.appspot.com/1589803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
