http://gwt-code-reviews.appspot.com/1604803/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
File user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
(right):

http://gwt-code-reviews.appspot.com/1604803/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java#newcode254
user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java:254:
w.write("assert owner.%s != null : \"UiField %s with 'provided = true'
was null\";", name, name);
I'm afraid that won't work as expected if ownerField actually is a
"getter" (getterCount > 1).

How about moving the assert 5 lines down, after the if/else block, and
emitting an '"assert %s != null", name' (i.e. using the local field or
variable, rather than the owner's one).

Also, instead of passing the same value twice, use %1$s to reference
twice the same argument:
w.write("foo %1$s bar %1$s baz", name);
See
http://docs.oracle.com/javase/6/docs/api/java/util/Formatter.html#syntax

http://gwt-code-reviews.appspot.com/1604803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to