should "&& !designTime.isDesignTime()" be added to the test?

Dunno, good question; I added Konstantin as a reviewer.

Konstantin, do you think the assertion in this patch should be skipped
during design time (the assertion is supposed to warn the user when
they've marked fields as provided=true but left them null, as without
this assertion the resulting NPE is somewhat cryptic).


http://gwt-code-reviews.appspot.com/1604803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to