http://gwt-code-reviews.appspot.com/1614803/diff/1/user/src/com/google/gwt/user/client/DOM.java
File user/src/com/google/gwt/user/client/DOM.java (right):

http://gwt-code-reviews.appspot.com/1614803/diff/1/user/src/com/google/gwt/user/client/DOM.java#newcode1192
user/src/com/google/gwt/user/client/DOM.java:1192: public static void
setInnerHTML(com.google.gwt.dom.client.Element elem, SafeHtml html) {
It seems like we should go one step further and add a
setInnerHTML(SafeHtml) method to com.google.gwt.dom.client.Element, and
call that directly?

(I'm not sure why these static methods are here anyway.
They're just wrappers around the Element methods.)

If we do keep the static method, it should probably take the other
version of Element just to be consistent with the rest of this class.

http://gwt-code-reviews.appspot.com/1614803/diff/1/user/src/com/google/gwt/user/client/ui/FormPanel.java
File user/src/com/google/gwt/user/client/ui/FormPanel.java (right):

http://gwt-code-reviews.appspot.com/1614803/diff/1/user/src/com/google/gwt/user/client/ui/FormPanel.java#newcode602
user/src/com/google/gwt/user/client/ui/FormPanel.java:602: private
interface IFrameTemplate extends SafeHtmlTemplates {
GWT code style wants inner classes and interfaces to be at the top of
the class, above the fields.

http://gwt-code-reviews.appspot.com/1614803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to