http://gwt-code-reviews.appspot.com/1614803/diff/8/user/src/com/google/gwt/user/client/DOM.java File user/src/com/google/gwt/user/client/DOM.java (right):
http://gwt-code-reviews.appspot.com/1614803/diff/8/user/src/com/google/gwt/user/client/DOM.java#newcode1192 user/src/com/google/gwt/user/client/DOM.java:1192: public static void setInnerHTML(com.google.gwt.dom.client.Element elem, SafeHtml html) { AFAIK, adding this method is a breaking change for anyone who passes null as the HTML value because the compiler cannot determine which method to use (ambiguous call). The implementation of Element.setInnerHTML() specifically supports null to clear the value, so its reasonable to expect that some users are using it. I suggest renaming this to setInnerSafeHtml(), and moving the method from DOM to Element. http://gwt-code-reviews.appspot.com/1614803/diff/8/user/src/com/google/gwt/user/client/ui/FormPanel.java File user/src/com/google/gwt/user/client/ui/FormPanel.java (right): http://gwt-code-reviews.appspot.com/1614803/diff/8/user/src/com/google/gwt/user/client/ui/FormPanel.java#newcode616 user/src/com/google/gwt/user/client/ui/FormPanel.java:616: DOM.setInnerHTML(dummy, IFrameTemplate.INSTANCE.get(frameName)); I'm not a fan of switching all of the elem.setInnerHTML() calls to DOM.setInnerHTML() calls. DOM is really an implementation class, and I don't think we should encourage people to use it. Instead, can you add Element.setInnerSafeHtml(SafeHtml) to Element, and delegate to Element.setInnerHTML(String)? http://gwt-code-reviews.appspot.com/1614803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
