http://gwt-code-reviews.appspot.com/1614807/diff/1/user/src/com/google/gwt/user/client/ui/ValuePicker.java File user/src/com/google/gwt/user/client/ui/ValuePicker.java (right):
http://gwt-code-reviews.appspot.com/1614807/diff/1/user/src/com/google/gwt/user/client/ui/ValuePicker.java#newcode50 user/src/com/google/gwt/user/client/ui/ValuePicker.java:50: public ValuePicker(CellList<T> cellList, ProvidesKey<T> keyProvider) {
Shouldn't the fix rather be to ask the CellList for its key provider?
Well, that seems logical; note that previously this cstr was already implicitly creating a separate SingleSelectionModel in the smodel field's initializer. So...perhaps we could use the CellList's selection model if it was an instance of SingleSelectionModel? But otherwise, yes, I've changed this cstr to not take a ProvidesKey but to ask the CellList for it. http://gwt-code-reviews.appspot.com/1614807/diff/1/user/src/com/google/gwt/user/client/ui/ValuePicker.java#newcode70 user/src/com/google/gwt/user/client/ui/ValuePicker.java:70: public ValuePicker(Renderer<T> renderer, ProvidesKey<T> keyProvider) {
I suppose keyProvider was meant to be passed to the CellList ctor?
Yes, good point. http://gwt-code-reviews.appspot.com/1614807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
