http://gwt-code-reviews.appspot.com/1614807/diff/6001/user/src/com/google/gwt/user/client/ui/ValuePicker.java
File user/src/com/google/gwt/user/client/ui/ValuePicker.java (right):
http://gwt-code-reviews.appspot.com/1614807/diff/6001/user/src/com/google/gwt/user/client/ui/ValuePicker.java#newcode116
user/src/com/google/gwt/user/client/ui/ValuePicker.java:116: if
((current == value) || (current != null && current.equals(value))) {
Hmm, there might be a need to use the key provider here instead of
equals()
If I fix this to use the keys, then the current test actually fails
because:
setValue(Foo@123[value=able])
setValue(Foo@456[value=able])
Does not accept the new Foo@456 value, but keeps the existing Foo@123
value, as it considers them equal, and so doesn't fire a change.
I suppose this makes sense? I ask only because I copy/pasted the
ValuePickerTest assertions that expect the Foo@456 set to change the
value from ValueListBoxTest.
And ValueListBox#setValue has a similar value-not-key check; do you
think that's a bug?
http://gwt-code-reviews.appspot.com/1614807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
