http://gwt-code-reviews.appspot.com/1601806/diff/1015/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java File user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java (right):
http://gwt-code-reviews.appspot.com/1601806/diff/1015/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java#newcode624 user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java:624: * resolving property values, won't automatically edit proxies that weren't On 2012/04/09 15:12:50, rdayal wrote:
I'm an autobean newbie, but shouldn't we change the diffing algorithm
so that it
doesn't actually cause edits to proxies? I mean, when you a do a diff,
that
should never happen, right?
The problem is that autobean has no notion of read only vs. editable beans. That's something specific to proxies and request factory, where getting a property (including from a visitor) will automatically edit its value if it's a proxy. http://gwt-code-reviews.appspot.com/1601806/diff/1015/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java#newcode1206 user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java:1206: * break backwards compatibility for those edge-cases). On 2012/04/09 15:12:50, rdayal wrote:
Maybe move this up into the method javadoc.
Done. http://gwt-code-reviews.appspot.com/1601806/diff/1015/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java#newcode1209 user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java:1209: /* On 2012/04/09 15:12:50, rdayal wrote:
This code is nearly identical to the code that you changed above. Can
you
refactor it?
Done. http://gwt-code-reviews.appspot.com/1601806/diff/1015/user/test/com/google/web/bindery/requestfactory/server/RequestPayloadJreTest.java File user/test/com/google/web/bindery/requestfactory/server/RequestPayloadJreTest.java (right): http://gwt-code-reviews.appspot.com/1601806/diff/1015/user/test/com/google/web/bindery/requestfactory/server/RequestPayloadJreTest.java#newcode1 user/test/com/google/web/bindery/requestfactory/server/RequestPayloadJreTest.java:1: package com.google.web.bindery.requestfactory.server; On 2012/04/09 15:12:50, rdayal wrote:
Copyright header.
Done. http://gwt-code-reviews.appspot.com/1601806/diff/1015/user/test/com/google/web/bindery/requestfactory/shared/impl/RequestPayloadTest.java File user/test/com/google/web/bindery/requestfactory/shared/impl/RequestPayloadTest.java (right): http://gwt-code-reviews.appspot.com/1601806/diff/1015/user/test/com/google/web/bindery/requestfactory/shared/impl/RequestPayloadTest.java#newcode2 user/test/com/google/web/bindery/requestfactory/shared/impl/RequestPayloadTest.java:2: On 2012/04/09 15:12:50, rdayal wrote:
Copyright header.
Done. http://gwt-code-reviews.appspot.com/1601806/diff/1015/user/test/com/google/web/bindery/requestfactory/shared/impl/RequestPayloadTest.java#newcode24 user/test/com/google/web/bindery/requestfactory/shared/impl/RequestPayloadTest.java:24: * too much things to the server. On 2012/04/09 15:12:50, rdayal wrote:
too much --> to many
Done. http://gwt-code-reviews.appspot.com/1601806/diff/1015/user/test/com/google/web/bindery/requestfactory/shared/impl/RequestPayloadTest.java#newcode51 user/test/com/google/web/bindery/requestfactory/shared/impl/RequestPayloadTest.java:51: public void testOperationPayload() throws Exception { On 2012/04/09 15:12:50, rdayal wrote:
Add a bit of doc here indicating what you're going to test.
Done. http://gwt-code-reviews.appspot.com/1601806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
