Ah, thanks - though it's interesting that there'd be a browser-specific failure in response to this type of change. Thanks for pointing out the difference though; I'll double-check.
On Mon Apr 30 13:22:34 GMT-400 2012, Freeland Abbott <fabb...@google.com> wrote: > Depending on which targets are failing, we also run with FF3, which Thomas > most likely doesn't.... > > On Mon Apr 30 11:10:32 GMT-400 2012, Rajeev Dayal <rda...@google.com> > wrote: > Thanks, Thomas. I'll take a look and see what's going on in our > environment. I wonder if it's an order-of-execution failure (implying that > there's statefulness between test runs that's not getting cleared). > > On Sun Apr 29 07:17:38 GMT-400 2012, <t.bro...@gmail.com> wrote: > > On 2012/04/29 10:42:26, tbroyer wrote: > > On 2012/04/27 16:11:29, rdayal wrote: > > > Hey Thomas, > > > > > > When I ran the tests after applying your change, I saw a failure in > > > EditorTest.test: > > > > > > aused by: junit.framework.AssertionFailedError: > expected=EditorBarTest > > > actual=FOO > > > at > > > > > com.google.web.bindery.requestfactory.gwt.client.ui.EditorTest.onSuccess(EditorTest.java:164) > > > > at > > > > > com.google.web.bindery.requestfactory.gwt.client.ui.EditorTest.onSuccess(EditorTest.java:1) > > > > at > > > > > com.google.web.bindery.requestfactory.shared.impl.AbstractRequest.onSuccess(AbstractRequest.java:129) > > > > at > > > > > com.google.web.bindery.requestfactory.shared.impl.AbstractRequestContext.processPayload(AbstractRequestContext.java:377) > > > > ... 28 more > > > > > > > > > Are you seeing the same thing? > > > On my local branch (off of r10773), "ant -f user/build.xml > test.dev.htmlunit > > -Dgwt.junit.testcase.includes=com/google/web/bindery/requestfactory/gwt/client/ui/EditorTest.class" > > > passes: > > > [junit] Running > > com.google.web.bindery.requestfactory.gwt.client.ui.EditorTest > > [junit] Tests run: 7, Failures: 0, Errors: 0, Time elapsed: 49,035 > sec > > > I'll rebase and see if that changes anything. > > Rebased upon r10958, "ant clean dist-dev" and then ran test.dev.htmlunit > and test.web.htmlunit, with the same BUILD SUCCESSFUL results. > > I tried with OpenJDK (6u24) and Oracle JDK (6u27) > (with the clean/dist-dev being run with OpenJDK; only the test being run > with both JDKs) > > Also tried with OpenJDK 7u3 (clean dist-dev, then test.dev.htmlunit; > using "JAVA_HOME=/usr/lib/jvm/java-7-openjdk-amd64/ ant ..." on the > command line; I'm not really sure the JAVA_HOME honored everywhere using > this technique); same (successful) results. > > http://gwt-code-reviews.appspot.com/1601806/<https://www.google.com/url?sa=D&q=http://gwt-code-reviews.appspot.com/1601806/> > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors