LGTM

http://gwt-code-reviews.appspot.com/1677803/diff/4001/user/src/com/google/gwt/core/server/ServerGwtBridge.java
File user/src/com/google/gwt/core/server/ServerGwtBridge.java (right):

http://gwt-code-reviews.appspot.com/1677803/diff/4001/user/src/com/google/gwt/core/server/ServerGwtBridge.java#newcode263
user/src/com/google/gwt/core/server/ServerGwtBridge.java:263: public
String getVersion() {
Too bad com.google.gwt.dev.About is part of the gwt-dev package and not
shared. :(

http://gwt-code-reviews.appspot.com/1677803/diff/4001/user/src/com/google/gwt/core/server/ServerGwtBridge.java#newcode273
user/src/com/google/gwt/core/server/ServerGwtBridge.java:273: public
void log(String message, Throwable e) {
Maybe Logger.getLogger(ServerGwtBridge.class).log() or allow the
ServerGwtBridge to be configured with some logger callback interface so
that ServletContext.log(), java.u.logging, or any other desired logger
can be used.

http://gwt-code-reviews.appspot.com/1677803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to