Thanks for the review.
http://gwt-code-reviews.appspot.com/1677803/diff/4001/user/src/com/google/gwt/core/server/ServerGwtBridge.java File user/src/com/google/gwt/core/server/ServerGwtBridge.java (right): http://gwt-code-reviews.appspot.com/1677803/diff/4001/user/src/com/google/gwt/core/server/ServerGwtBridge.java#newcode263 user/src/com/google/gwt/core/server/ServerGwtBridge.java:263: public String getVersion() { On 2012/04/18 21:45:01, cromwellian wrote:
Too bad com.google.gwt.dev.About is part of the gwt-dev package and
not shared.
:(
I thought about it, but we don't have an easy way to share classes between gwt-dev and gwt-user. Plus, it might be confusing for shared code -- do we consider the client or the server? I'm not sure this should even really be here, but the API already had it. http://gwt-code-reviews.appspot.com/1677803/diff/4001/user/src/com/google/gwt/core/server/ServerGwtBridge.java#newcode273 user/src/com/google/gwt/core/server/ServerGwtBridge.java:273: public void log(String message, Throwable e) { On 2012/04/18 21:45:01, cromwellian wrote:
Maybe Logger.getLogger(ServerGwtBridge.class).log() or allow the
ServerGwtBridge
to be configured with some logger callback interface so that ServletContext.log(), java.u.logging, or any other desired logger can
be used. I don't want to add a bunch, so I will just use j.u.logging. http://gwt-code-reviews.appspot.com/1677803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
