it looks like there's disagreement on the implementation

My recollection is that zhuyi's original patch used a static variable to
store the "do we serialize final fields or not" state. However, the
variable is a per-module configuration, so putting it as static could
have lead to non-determinism if multiple modules were getting compiled
at the same time.

I took zhuyi's work, killed the static, and instead changed various
methods to pass around the context so that "serialize final fields or
not" could be turned on/off at the right place.

zhuyi incorporated that into this patch, so, no statics, so I think
we're good to go. (Correct me if I'm wrong, John.)

My only thought was that I wanted to go further and *always* serialize
final fields, which would be cleaner as we could avoid the somewhat
complex conditional behavior, but that was deemed to much of a breaking
change.

http://gwt-code-reviews.appspot.com/1380807/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to