I've fix the test (I thought it was environmental, but it happened to be
a 2-char-long mistake: .to() instead of .fire(): the request was never
sent, so finishTestAndReset was never called (from the response)).
That wasn't an issue in "JRE" tests, where everything runs
synchronously; so the "response" code wasn't being run at all in this
case.
I also split testChangedEdit in smaller chunks, and added tests for
lists of simple values.
As for the server-side errors, they happen to be expected ones. The
second one is explicitly called out as such ("The following exception
about an entity with a null version is expected"), whereas the first one
comes from RequestFactoryTest#testEmptyRequestZeroLength(). If we wanted
to have a log similar to the other exception, I think we could use
GWT.log(), or maybe even System.err.println() on the client-side, but
that would only work in DevMode.
http://gwt-code-reviews.appspot.com/1601806/diff/27001/user/test/com/google/web/bindery/requestfactory/server/RequestPayloadJreTest.java
File
user/test/com/google/web/bindery/requestfactory/server/RequestPayloadJreTest.java
(right):
http://gwt-code-reviews.appspot.com/1601806/diff/27001/user/test/com/google/web/bindery/requestfactory/server/RequestPayloadJreTest.java#newcode24
user/test/com/google/web/bindery/requestfactory/server/RequestPayloadJreTest.java:24:
public class RequestPayloadJreTest extends RequestPayloadTest {
On 2012/05/08 17:55:55, rdayal wrote:
javadoc
Done.
http://gwt-code-reviews.appspot.com/1601806/diff/27001/user/test/com/google/web/bindery/requestfactory/shared/impl/RequestPayloadTest.java
File
user/test/com/google/web/bindery/requestfactory/shared/impl/RequestPayloadTest.java
(right):
http://gwt-code-reviews.appspot.com/1601806/diff/27001/user/test/com/google/web/bindery/requestfactory/shared/impl/RequestPayloadTest.java#newcode47
user/test/com/google/web/bindery/requestfactory/shared/impl/RequestPayloadTest.java:47:
protected static class RecordingRequestTransport implements
RequestTransport {
On 2012/05/08 17:55:55, rdayal wrote:
javadoc
Done.
http://gwt-code-reviews.appspot.com/1601806/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
