Would be great to get it into 2.5 ;-)
http://gwt-code-reviews.appspot.com/1623803/diff/9001/dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java File dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java (right): http://gwt-code-reviews.appspot.com/1623803/diff/9001/dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java#newcode1577 dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java:1577: } On 2012/01/05 21:04:59, scottb wrote:
This seems a pure win, in isolation. I would just couch it as an
optimization
tho, and not reference issue 4301.
Done. http://gwt-code-reviews.appspot.com/1623803/diff/9001/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java (right): http://gwt-code-reviews.appspot.com/1623803/diff/9001/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java#newcode1678 dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java:1678: JsName toStringName = objectScope.declareName("toString"); On 2012/01/05 21:04:59, scottb wrote:
Remind me: if "toString" is already declared, this just returns the
existing
JsName?
Yes, there's a cache in each JsScope instance. http://gwt-code-reviews.appspot.com/1623803/diff/9001/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java#newcode1681 dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java:1681: toStringRef.setQualifier(globalTemp.makeRef(sourceInfo)); On 2012/01/05 21:04:59, scottb wrote:
This seems deceptively side-effect-y. This method should just take a
qualifier
JsExpression as an arg. Then you can copy the qualifier's SourceInfo.
I'm afraid I don't understand what you're saying :-/ http://gwt-code-reviews.appspot.com/1623803/diff/9001/dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java File dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java (right): http://gwt-code-reviews.appspot.com/1623803/diff/9001/dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java#newcode271 dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java:271: " public String toString() { return null; }" + On 2012/01/05 21:04:59, scottb wrote:
"return this" to avoid future tests tripping over null propagation
optimizations Done. http://gwt-code-reviews.appspot.com/1623803/diff/9001/user/super/com/google/gwt/emul/java/lang/String.java File user/super/com/google/gwt/emul/java/lang/String.java (right): http://gwt-code-reviews.appspot.com/1623803/diff/9001/user/super/com/google/gwt/emul/java/lang/String.java#newcode962 user/super/com/google/gwt/emul/java/lang/String.java:962: * magic: this method is only used during compiler optimizations; the generated JS will instead alias On 2012/01/05 21:04:59, scottb wrote:
Capitalize Magic.
Done. http://gwt-code-reviews.appspot.com/1623803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
