[gwt-contrib] Re: Fixes issue 4301: ensures all strings "generated" by GWT are JS string values. (issue1623803)

[t . broyer]

http://gwt-code-reviews.appspot.com/1623803/diff/25001/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
(right):

http://gwt-code-reviews.appspot.com/1623803/diff/25001/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java#newcode1732
dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java:1732:
private JsNameRef createNativeToStringRef(JsExpression expr) {
On 2012/05/15 13:41:45, scottb wrote:

nit: "qualifier" rather than "expr"

Done.

http://gwt-code-reviews.appspot.com/1623803/diff/25001/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java#newcode2107
dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java:2107:
rhs = createNativeToStringRef(globalTempRef);
On 2012/05/15 13:41:45, scottb wrote:

Actually, you need to make the ref twice, otherwise you end up with

the same

object in the tree twice, once on the LHS and once on the RHS.  Only

completely

stateless objects like numeric literals are allowed to be in the tree

in more

than one place.

Done.

http://gwt-code-reviews.appspot.com/1623803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors