Okay, yeah, a TODO is fine as it looks kind of difficult. I see now that
we are calling ValueProxy.equals() which calls deepEquals(). Worse, when
AutoBeanUtils.diff() is called with a ValueProxy, it looks like we will
be doing a deep equality check twice. (For the "fast" check and again
for each property.) And I'm not entirely sure whether deepEquals() will
call equals() at some deeper level.

I suppose it's just a performance thing if the code is correct, but I
don't see how anyone could be confident of that.


http://gwt-code-reviews.appspot.com/1601806/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to