On Friday, May 18, 2012 7:32:15 PM UTC+2, Brian Slesinsky wrote: > > On Thu, May 17, 2012 at 5:30 PM, <[email protected]> wrote: > > On 2012/05/17 22:52:23, skybrian wrote: > > > (one of the difficulties is that the only way to get at properties of an > > AutoBean is to "visit" it, so I think we'd still need some flag to turn > > off "auto-editing of proxies on property retrieval") > > I'm rather allergic to flags that change how basic methods work, but > it does seems like AutoBeans should have a "reflection" or "backdoor" > API for trusted code to do its thing, preferably stateless. >
Have a look at http://gwt-code-reviews.appspot.com/1357805 I think I could use that as a basis for a refactoring without the 'diffing' flag. Note that there's still the isLocked flag for auto-editing (used in BaseProxyCategory); I think it could be hidden in some maybeEditProxy method if that's OK for you. > In this patch, can avoid making the "diffing" flag public, so we can > easily change the implementation later and remove it? Well, it's in an "impl" class, so we already have an implicit contract that it might change at any time. Done, however. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
