On 2012/06/07 07:39:38, ehwang wrote:
Thanks for the review!
For the vendor prefixes, I ended up creating a separate helper class, VendorPrefixes. It doesn't keep a master list of prefixes. I decided
that was
more future-proof, and the "-foo-" syntax is specifically reserved by
the W3C
for vendor prefixes: http://www.w3.org/TR/CSS21/syndata.html#vendor-keywords
Yeah, I was wondering too whether it wouldn't be better; totally agree it indeed is: there are also -khtml- and -apple- as synonymous for -webkit-, but also -wap-, -epub- and -xv- (see http://peter.sh/experiments/vendor-prefixed-css-property-overview/ ), so a generic approach is definitely better (even better as it matches the spec too ;-) ) http://gwt-code-reviews.appspot.com/1727803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
