http://gwt-code-reviews.appspot.com/1727803/diff/1/user/src/com/google/gwt/resources/css/RtlVisitor.java
File user/src/com/google/gwt/resources/css/RtlVisitor.java (right):

http://gwt-code-reviews.appspot.com/1727803/diff/1/user/src/com/google/gwt/resources/css/RtlVisitor.java#newcode370
user/src/com/google/gwt/resources/css/RtlVisitor.java:370: if
(parts.length > 2 && "".equals(parts[0])
Notes:
- SplitThenSetLookup is my original version in patch #1.
- SetLookupThenSplit is your first suggestion, extracting the prefix
first.
- LoopPrefixesThenSplit is your second suggestion.
- GuavaSplitter does the loop-prefixes, then uses Splitter.
- GuavaCaseFormat does the loop-prefixes, then uses
CaseFormat.LOWER_HYPHEN.to(CaseFormat.UPPER_CAMEL, name).

And a slight clarification: the speed improvement from switching to
Splitter is independent of using the new VendorPrefixes helper class.

The current approach strips the vendor prefix with the utility (by
searching for two hyphens like your second suggestion, minus set
lookup), then uses Splitter.

http://gwt-code-reviews.appspot.com/1727803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to