Reviewers: skybrian, rdayal,
https://gwt-code-reviews.appspot.com/1729805/diff/1/build.xml
File build.xml (left):
https://gwt-code-reviews.appspot.com/1729805/diff/1/build.xml#oldcode57
build.xml:57: <gwt.ant dir="dev/codeserver" />
"ant testrf" failed because it tried to call compile.tests in
dev/codeserver, which doesn't exist.
Moreover, the 'codeserver' target (called by 'build') calls this target,
which would result in double building dev/codeserver.
Clearly, there was no point in providing "ant codeserver" if "ant dev"
has the same output. My bad.
https://gwt-code-reviews.appspot.com/1729805/diff/1/user/test/com/google/web/bindery/requestfactory/apt/EntityProxyCheckDomainMapping.java
File
user/test/com/google/web/bindery/requestfactory/apt/EntityProxyCheckDomainMapping.java
(right):
https://gwt-code-reviews.appspot.com/1729805/diff/1/user/test/com/google/web/bindery/requestfactory/apt/EntityProxyCheckDomainMapping.java#newcode31
user/test/com/google/web/bindery/requestfactory/apt/EntityProxyCheckDomainMapping.java:31:
class Domain {
Members of interface are always 'public static'; I removed the explicit
modifiers to test that RFIV still sees it as 'public static' (IIRC,
that's not always the case with Java reflection; it appears to be OK
with the "mirrors" from javax.lang.model)
Description:
ValidationTool doesn't flag abstract classes as non-default-instantiable
Fixes issue 7414
Please review this at https://gwt-code-reviews.appspot.com/1729805/
Affected files:
M build.xml
M user/src/com/google/web/bindery/requestfactory/apt/DomainChecker.java
M user/src/com/google/web/bindery/requestfactory/apt/Messages.java
M
user/test/com/google/web/bindery/requestfactory/apt/EntityProxyCheckDomainMapping.java
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
