http://gwt-code-reviews.appspot.com/1727807/diff/1/user/src/com/google/gwt/editor/client/impl/SimpleViolation.java File user/src/com/google/gwt/editor/client/impl/SimpleViolation.java (right):
http://gwt-code-reviews.appspot.com/1727807/diff/1/user/src/com/google/gwt/editor/client/impl/SimpleViolation.java#newcode146 user/src/com/google/gwt/editor/client/impl/SimpleViolation.java:146: baseDelegate.recordError(error.getMessage(), null, How about trying again with a shorter path? (in case error.getPath() is a dotted path) http://gwt-code-reviews.appspot.com/1727807/diff/1/user/test/com/google/gwt/editor/client/EditorErrorTest.java File user/test/com/google/gwt/editor/client/EditorErrorTest.java (right): http://gwt-code-reviews.appspot.com/1727807/diff/1/user/test/com/google/gwt/editor/client/EditorErrorTest.java#newcode255 user/test/com/google/gwt/editor/client/EditorErrorTest.java:255: assertSame(editor.addressEditor, error.getEditor()); Nit: the message "failed1" is a bit misleading if the error is delivered to the correct sub-editor. http://gwt-code-reviews.appspot.com/1727807/diff/1/user/test/com/google/gwt/editor/client/EditorErrorTest.java#newcode279 user/test/com/google/gwt/editor/client/EditorErrorTest.java:279: assertSame(editor, error.getEditor()); In that case (and "failed5"), I think it'd be better to have the error delivered to the 'editor.addressEditor' (resp. 'editor.addressEditor.city') than at the top-level. http://gwt-code-reviews.appspot.com/1727807/diff/1/user/test/com/google/gwt/editor/client/SimpleConstraintViolation.java File user/test/com/google/gwt/editor/client/SimpleConstraintViolation.java (right): http://gwt-code-reviews.appspot.com/1727807/diff/1/user/test/com/google/gwt/editor/client/SimpleConstraintViolation.java#newcode27 user/test/com/google/gwt/editor/client/SimpleConstraintViolation.java:27: * A simple implementation of ConstraintViolation, for testing. If it's for testing, maybe move it to the 'testing' sub-package. Alternately, how about using com.google.gwt.validation.client.impl.ConstraintViolationImpl instead in the tests? http://gwt-code-reviews.appspot.com/1727807/diff/1/user/test/com/google/gwt/editor/client/SimpleConstraintViolation.java#newcode70 user/test/com/google/gwt/editor/client/SimpleConstraintViolation.java:70: return null; Maybe throw new UnsupportedOperationException() instead? http://gwt-code-reviews.appspot.com/1727807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
